Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ABW-2128 Verify Dapps #711

Merged
merged 10 commits into from
Sep 6, 2023
Merged

ABW-2128 Verify Dapps #711

merged 10 commits into from
Sep 6, 2023

Conversation

kugel3
Copy link
Contributor

@kugel3 kugel3 commented Sep 4, 2023 •
edited
Loading

Jira ticket: ABW-2128

Description

NOTE: Currently the Gumball machine will fail verification, since it is setting dapp_definitions instead of dapp_definition.

  • Verifies the claimed_websites <-> well-known two way link for incoming dApp interactions
  • Distinguish between unknown (validation failed) dapps and merely unnamed ones
  • Add nav bar with close button for dapp details
  • Properly placed quotation marks for the nickname in persona details
  • Refactor dApp validation
  • Don't show the amount of a fungible resource in the context of a transfer (this should be done more elegantly later)

Screenshot

INVALID request, with developer mode ON
https://github.com/radixdlt/babylon-wallet-ios/assets/123396602/45b597c4-9774-4dcb-a8ba-d383e566bc24

VALID request, with developer mode OFF
https://github.com/radixdlt/babylon-wallet-ios/assets/123396602/001be684-d0a9-49be-950a-8c037b81c227

INVALID request, with developer mode OFF
image

Dapp Details
imageimage

Persona Details
image

Fungible Resource Details (in transfer context)
image

PR submission checklist

  • I have tested account to account transfer flow and have confirmed that it works

@kugel3 kugel3 force-pushed the ABW-2128_Verify-dApps branch 2 times, most recently from 7d4775b to 7338564 Compare September 5, 2023 08:15
@kugel3 kugel3 force-pushed the ABW-2128_Verify-dApps branch 4 times, most recently from 217b18a to 2a1d82a Compare September 5, 2023 10:01
CyonAlexRDX
CyonAlexRDX approved these changes Sep 5, 2023
View reviewed changes
Copy link
Contributor

@CyonAlexRDX CyonAlexRDX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good job!

@kugel3 kugel3 merged commit c9cdc29 into main Sep 6, 2023
10 checks passed
@kugel3 kugel3 deleted the ABW-2128_Verify-dApps branch September 6, 2023 05:45
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CyonAlexRDX CyonAlexRDX CyonAlexRDX approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kugel3 @CyonAlexRDX