ABW-2179 Update Manifest Mutation Cost Addition Estimates #712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maciek-rdx
changed the title
maciek-rdx
changed the title
maciek-rdx
force-pushed
the
ABW-2178-fees
branch
from
b544d8f
to
188b995
Compare
kugel3
approved these changes
Sep 5, 2023
CyonAlexRDX
approved these changes
Sep 5, 2023
There was a problem hiding this comment.
Looks good, but please change to DRAFT and mark DO NOT MERGE, until you have tested MANY complex transactions.
We are lowering the costs, so assert that you can perform various complex transactions, e.g. test through all of Gumball Club.
If it does not work, we need to WAIT merging this until RCnet 3.1 is live.
maciek-rdx
added
DO NOT MERGE
|
I tested all Gumball examples, didnt find anything wrong. I'll merge it and leave it for @umair-rdx to test more. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira ticket: paste link here
Source of values
Notes
In our code, there is one missing constant and one is unused. Thats fine for now though.
PR submission checklist