fix bug where user could input an address on the wrong network. #715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maciek-rdx
approved these changes
Sep 5, 2023
… on current network
maciek-rdx
approved these changes
Sep 5, 2023
| @@ -17,17 +17,48 @@ public struct ChooseReceivingAccount: Sendable, FeatureReducer { | |||
|
|
|||
| var manualAccountAddressFocused: Bool = false | |||
|
|
|||
| public enum AddressValidation: Sendable, Hashable { | |||
| case valid(AccountAddress) | |||
| case wrongNetwork(AccountAddress, incorrectNetwork: UInt8) | |||
There was a problem hiding this comment.
Do we need the incorrectNetwork? Seems to be unused
| case .wrongNetwork: | ||
| return .error("Address is not valid on current network") // FIXME: Strings | ||
| case let .valid(validAddress): | ||
| if state.chooseAccounts.filteredAccounts.contains(where: { $0 == validAddress }) { |
There was a problem hiding this comment.
We can do just contains(validAddress) I guess, but likely not worth to trigger one more build at this moment. Cosmetics
CyonAlexRDX
deleted the
ABW-2190_crit_bug_recipient_address_changes_in_review
branch
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bug where user could input an address on the wrong network - related Slack convo:
https://rdxworks.slack.com/archives/C031A0V1A1W/p1693924609445919
RPReplay_Final1693929301.MP4