[ABW-2065] Dont show Cancelled error to user #721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vent scheduling of CancellationError
maciek-rdx
approved these changes
Sep 6, 2023
CyonAlexRDX
commented
Sep 6, 2023
| @@ -9,6 +10,21 @@ extension ErrorQueue: DependencyKey { | |||
| return Self( | |||
| errors: { errors.share().eraseToAnyAsyncSequence() }, | |||
| schedule: { error in | |||
|
|
|||
| if error is CancellationError { | |||
| loggerGlobal.warning("Suppressed `CancellationError`, i.e. preventing scheduling of this error on the ErrorQueue") | |||
There was a problem hiding this comment.
I guess we wanna suppress these errors, not relevant to user... right?
CyonAlexRDX
commented
Sep 6, 2023
| nsError.domain == NSURLErrorDomain, | ||
| nsError.code == NSURLErrorCancelled | ||
| { | ||
| loggerGlobal.warning("Suppressed NSError with domain `NSURLErrorDomain`, i.e. preventing scheduling of this error on the ErrorQueue. \nDetails: code: \(nsError.code) - description: \"\(nsError.localizedDescription)\"") |
There was a problem hiding this comment.
Contrary to what my video in PR discription said, I updated to only suppress when nsError.code == NSURLErrorCancelled
kugel3
reviewed
Sep 6, 2023
kugel3
approved these changes
Sep 6, 2023
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira ticket: ABW-2065
Yes oooops, I used wrong git branch name, c'est la vie
Description
Prevent scheduling NSError where code is NSURLErrorCancelled also prevent scheduling of CancellationError
Video
BEFORE
RPReplay_Final1693995609.MP4
AFTER
ABW-2065_prevent_display_of_error_alert_for_cancellation_errors.mov
PR submission checklist