ABW-1957, ABW-1956 X button on success screen #722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CyonAlexRDX
reviewed
Sep 6, 2023
| WithNavigationBar { | ||
| viewStore.send(.closeButtonTapped) | ||
| } content: { | ||
| WithViewStore(store, observe: ViewState.init, send: absurd) { viewStore in |
There was a problem hiding this comment.
@maciek-rdx send: absurd ? :P
There was a problem hiding this comment.
Yeah, its switch never {} 🙂 But not necessary in that case, can be just ommited 🧹
CyonAlexRDX
approved these changes
Sep 6, 2023
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira ticket:
Description
Seems that pure
SwiftUIis more reliable and "simpler" in that case.Notes
Not sure if we should deprecate the
@Dependency(\.dismiss)entirely 🤔?Video
RPReplay_Final1694005220.MP4
PR submission checklist