Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add assets list empty states #755

Merged
merged 4 commits into from
Sep 14, 2023
Merged

Add assets list empty states #755

merged 4 commits into from
Sep 14, 2023

Conversation

GhenadieVP
Copy link
Contributor

@GhenadieVP GhenadieVP commented Sep 13, 2023 •
edited by CyonAlexRDX
Loading

Added empty states for AssetsView.

What was done:

  • Introduced the empty state view, reused for all resource types.
  • Updated AssetsView to handle empty-nonEmpty states.

Demo:

RPReplay_Final1694614762.MP4

CyonAlexRDX
CyonAlexRDX approved these changes Sep 14, 2023
View reviewed changes
Copy link
Contributor

@CyonAlexRDX CyonAlexRDX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice UI improvment

@GhenadieVP GhenadieVP merged commit 5382e7a into main Sep 14, 2023
5 checks passed
@GhenadieVP GhenadieVP deleted the fix/ABW-2108-i-os-alpha-0-3-1-empty-states-not-showing-you-have-no branch September 14, 2023 13:03
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CyonAlexRDX CyonAlexRDX CyonAlexRDX approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GhenadieVP @CyonAlexRDX