Bug fix transfer after network switch #774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GhenadieVP
reviewed
Sep 19, 2023
| action: App.ChildAction.onboardingCoordinator, | ||
| then: { OnboardingCoordinator.View(store: $0) } | ||
| ) | ||
| VStack { |
There was a problem hiding this comment.
Should the spacing be zero?
CyonAlexRDX
commented
Sep 19, 2023
| .task { @MainActor in | ||
| await store.send(.view(.task)).finish() | ||
| } | ||
| .presentsLoadingViewOverlay() |
There was a problem hiding this comment.
You are flipping the order of loading view overlay and banner, is that intentional? It might have some (unwanted) affect?
There was a problem hiding this comment.
You did the flipping, I just didn't revert it, so it's not intentional from my side...
There was a problem hiding this comment.
Haha lol, unflip my flip please :)
GhenadieVP
approved these changes
Sep 19, 2023
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduce observation of AppState
RPReplay_Final1695118491.MP4