Gh release fix #787
Merged
Gh release fix #787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CyonAlexRDX
commented
Sep 22, 2023
|
|
||
| sh('git fetch --tags') | ||
| most_recent_tags = sh("git tag | grep #{flavour} | sort -r | head -2").split("\n") | ||
|
|
||
| changelog = rev_changelog(flavour, most_recent_tags) | ||
| versions_string = dependencies_with_hyperlinks() | ||
|
|
||
| release_description = "**Dependencies**: \n" + versions_string + "\n\n**Changelog**: \n" + rev_changelog |
There was a problem hiding this comment.
oops, I accidentally tried to concatenate a function! not a variable... 🤦♂️ untyped langauges 🙃🙃🙃
CyonAlexRDX
commented
Sep 22, 2023
| false | ||
| end | ||
|
|
||
| private_lane :locate_dsym do |options| |
CyonAlexRDX
commented
Sep 22, 2023
| @@ -42,7 +42,7 @@ platform :ios do | |||
| build_number: build_number | |||
| ) | |||
|
|
|||
| build_app( | |||
| build_ios_app( | |||
There was a problem hiding this comment.
bit cleaner imo
GhenadieVP
approved these changes
Sep 22, 2023
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rev_changeloginstead ofchangelogSuccessfully produced GH release with DSYMs