[ABW-2289] Fastlane: Skip GH Release for Alpha/PreAlpha && Dont show quotation marks around empty strings in Persona Data name #788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CyonAlexRDX
changed the title
kugel3
approved these changes
Sep 22, 2023
kugel3
reviewed
Sep 22, 2023
| \(firstLine) | ||
| "\(nickname)" | ||
| """ | ||
| let quotedNicknameOrEmpty: String? = nickname.nilIfEmpty.map { "\"\($0)\"" } |
There was a problem hiding this comment.
I know you love long names but this one is a lie, it will never be empty. Instead of empty it will be nil. And the optionality is built into the type, so it would be more true to call it nonEmptyQuotedNickname...
I also know how much you love NonEmptyString, you could use that. Would also make the compactMap less sad.
CyonAlexRDX
changed the title
CyonAlexRDX
deleted the
ABW-2289_remove_quotation_marks_in_persona_details
branch
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira ticket ABW-2289
Bonus: Fastlane: Disable GH Release for Alpha and PreAlpha