No phone Auth flow #801
Merged
No phone Auth flow #801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GhenadieVP
commented
Sep 27, 2023
| return .run { send in | ||
| await send(.internal(.loadProfileOutcome(loadProfile()))) | ||
| } | ||
| return verifyPasscode() |
There was a problem hiding this comment.
Verify the passcode again when user taps unlock. This was the main source of the bug, as loading the profile will succeed and then the user will be redirected to home screen,
GhenadieVP
commented
Sep 27, 2023
| state.biometricsCheckFailed = true | ||
| errorQueue.schedule(error) |
There was a problem hiding this comment.
Show any error, in some cases the kechain will throw the error that there is no keychain configured.
CyonAlexRDX
approved these changes
Sep 27, 2023
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://radixdlt.atlassian.net/browse/ABW-2335
handle no auth flows + moving gateways check to main + some dependencies clean up.
Demo:
RPReplay_Final1695826982.MP4