[ABW-2378] Set current gateway to mainnet after import #812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CyonAlexRDX
commented
Sep 29, 2023
| @@ -25,7 +25,7 @@ public struct ProfileSnapshot: | |||
|
|
|||
| /// Settings for this profile in the app, contains default security configs | |||
| /// as well as display settings. | |||
| public let appPreferences: AppPreferences | |||
| public private(set) var appPreferences: AppPreferences | |||
There was a problem hiding this comment.
Preferably we want the Snapshot to be immutable, but in this case it would just be a hassle to "roundtrip" through Profile in ProfileStore's function changeProfileSnapshot:to, thus we allow this, but still make the setter private, having to go through changeCurrentToMainnetIfNeeded.
GhenadieVP
approved these changes
Sep 29, 2023
CyonAlexRDX
deleted the
ABW-2378_set_current_GW_to_mainnet_after_import
branch
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira ticket: ABW-2378
Description
Change current network (gateway) to
.mainnetafter having finished importing aProfile(wallet backup data).Prevents
General soundness measure, safe to do since all Profiles should contain
.mainnetaccounts.How to test
You can use this Profile (requires RDX Works account)
Mnemonic is: