[ABW-2484] Mono target #842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GhenadieVP
approved these changes
Oct 16, 2023
| "revision" : "33f7e93be5d4ec027d42af77a8ec4680d1862ad2", | ||
| "version" : "11.6.4" | ||
| "revision" : "93c8dc78fbc0aa3538a0db460eb389d4180af242", | ||
| "version" : "11.3.1" |
There was a problem hiding this comment.
- unintentional, will fix
| @@ -1,12 +1,4 @@ | |||
| import AppPreferencesClient | |||
| import AsyncExtensions | |||
| import ClientPrelude | |||
| import ComposableArchitecture // actually CasePaths... but CI fails if we do `import CasePaths` 🤷♂️ | |||
There was a problem hiding this comment.
Minor - would this still fail if importing just CasePaths with this PR>
There was a problem hiding this comment.
nope, I dont think so, I can try it post this PR!
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira ABW-2484
Description
This PR completely removes SPM - Swift Package Manager - and moves to a pure
.xcodeprojXcode based solution, and not as a multiplatform app, but as a iOS only app. What this means is that all the source code is put in one single (app) target, instead of ~100 targets we had before.The only behaviour changes of this PR is using the changes here #811
Otherwise the app should behave exactly as it did before.
Rationale
Why do this? Lets start with answering the question: "Why did we use many targets and SPM to begin with?" - we did it because we based our architecture on Isowords app, which felt logical since we use Pointfree's TCA, and Isowords is their showcase app for TCA.
It has now been 15 months since our first commit and we have been six iOS developers in this code base, and we have all felt the pains that super-many-targets architecture entails, which is:
Result
1.
clean build runtime is reduced by 50%2.
clean build testtime on CI is reduced by 55%3. Logs in CI is reduced by is reduced by 55%
4. Effect of drastic reduce CI run time, is a lot of saved money for RDX works 🤑
Additional Changes
#if os(iOS)which we have talked about a lotswiftformatconfig to useswift 5.9which changed from{}()->{}in lots of places, and also removed superfluousreturn.macfrom fastlaneDecimalin GatewayAPI folder to useFoundation.Decimal, manually, meaning this change will be overriden once we run generate GW models. We should fix this in a coming PR.