Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix fastlane scan #858

Merged
merged 7 commits into from
Oct 20, 2023
Merged

Fix fastlane scan #858

merged 7 commits into from
Oct 20, 2023

Conversation

CyonAlexRDX
Copy link
Contributor

@CyonAlexRDX CyonAlexRDX commented Oct 20, 2023 •
edited
Loading

Description

bundle exec fastlane tests failed

  • locally due to RadixWalletTests requiring signing, and sometimes due to Mac being used
  • sometimes in CI due to Mac being used

This fixes that.

Changes

  • Remove swiftgen build phase, it seems it might have caused issues with code signing, since swiftgen mac target is used to format, also it can break CI... so best go back to have to manually call swiftgen locally after having updated resources
  • Update code sign settings for RadixWalletTests, should hopefully be more robust now (no code sign)
  • Remove mac / ipad / mac catalyst as supported platforms from RadixWalletTests
  • Change from seemlingly broken SCAN_DESTINATION to SCAN_DEVICE which seems to... "just work".
  • Comment out PeerConnectionNegotiationTests which never finish, causing CI to never finish.

This was referenced Oct 20, 2023
Merged
Merged
@CyonAlexRDX CyonAlexRDX changed the title Fix fastlane scan failing Fix fastlane scan Oct 20, 2023
@CyonAlexRDX CyonAlexRDX merged commit bfabc34 into main Oct 20, 2023
5 checks passed
@CyonAlexRDX CyonAlexRDX deleted the fix_fastlane_scan_failing branch October 20, 2023 12:51
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GhenadieVP GhenadieVP GhenadieVP approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CyonAlexRDX @GhenadieVP