Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ABW-2415] Additions to Account Preferences #868

Merged
merged 6 commits into from
Oct 27, 2023
Merged

[ABW-2415] Additions to Account Preferences #868

merged 6 commits into from
Oct 27, 2023

Conversation

kugel3
Copy link
Contributor

@kugel3 kugel3 commented Oct 25, 2023 •
edited by jira bot
Loading

Jira ticket: ABW-2415

Description

We want to show the full account address, and the button to show the QR code, right in Account Preferences, as seen in Figma.

Notes

The QR code button is also removed from Dev preferences.

How to test

  • Verify that the full address and the QR code button show up where they should, and that they work as expected
  • Also verify that other address views look and behave as before

Screenshot

image

PR submission checklist

  • I have tested account to account transfer flow and have confirmed that it works

CyonAlexRDX
CyonAlexRDX approved these changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@CyonAlexRDX CyonAlexRDX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kugel3 kugel3 merged commit e6a92bc into main Oct 27, 2023
6 checks passed
@kugel3 kugel3 deleted the ABW-2414_qr-code branch October 27, 2023 14:39
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CyonAlexRDX CyonAlexRDX CyonAlexRDX approved these changes

@GhenadieVP GhenadieVP GhenadieVP approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kugel3 @CyonAlexRDX @GhenadieVP