-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deposit instruction based on deposit rules #877
Deposit instruction based on deposit rules #877
Conversation
RadixWallet/Clients/OnLedgerEntitiesClient/Helpers/OnLedgerEntitiesClient+CreateEntity.swift
Outdated
Show resolved
Hide resolved
…t-accounts-when-not-required-try-deposit-deposit
RadixWallet/Clients/OnLedgerEntitiesClient/Helpers/OnLedgerEntitiesClient+CreateEntity.swift
Outdated
Show resolved
Hide resolved
RadixWallet/Clients/OnLedgerEntitiesClient/OnLedgerEntitiesClient+Live.swift
Show resolved
Hide resolved
RadixWallet/Features/AssetTransferFeature/AssetTransfer+Reducer.swift
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Github seems to think there is an error in a test
RadixWalletTests/Features/AssetTransferTests/AssetTransferDepositRuleTests.swift
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice! Need to change tests to use withTimeLimit
, also what is the plan for:
// TODO: Temporary revert of checking if the receiving account is a ledger account
let isSoftwareAccount = true // !receivingAccount.isLedgerAccount
not to be addressed by this PR? do we have another ticket for that? or should we not at all have logic be dependent on if ledger or not?
RadixWalletTests/Features/AssetTransferTests/AssetTransferDepositRuleTests.swift
Show resolved
Hide resolved
RadixWallet/Features/AssetTransferFeature/AssetTransfer+Reducer.swift
Outdated
Show resolved
Hide resolved
RadixWalletTests/Features/AssetTransferTests/AssetTransferDepositRuleTests.swift
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, good job!
Jira issue: https://radixdlt.atlassian.net/browse/ABW-2361, https://radixdlt.atlassian.net/browse/ABW-2516
When transferrin between user accounts, determine the deposit instruction(and by implication the requirement of additional signature) based on the account deposit rule.
If an user owned account, they are about to deposit into, would allow the deposit to happen without requiring a signature the Wallet will not add it.
Demos
AcceptAll deposit rule:
try_deposit_or_abort
instruction is used.deposit
instruction is used.RPReplay_Final1698693118.mov
AcceptKnown deposit rule
try_deposit_or_abort
instruction is used.deposit
instruction is used.deposit
instruction is used.try_deposit_or_abort
instruction is used.RPReplay_Final1698693407.mov
DenyAll deposit rule
deposit
instruction is used.try_deposit_or_abort
instruction is used.RPReplay_Final1698693239.mov