Debug Keychain View - delete mnemonics #900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CyonAlexRDX
changed the title
CyonAlexRDX
changed the title
Sajjon
reviewed
Nov 9, 2023
| ) -> [String] { | ||
| keychain.allItems() | ||
| .filter { | ||
| if let isSynchronizable = $0["synchronizable"] as? Bool, let needle = needleIsSynchronizable { |
There was a problem hiding this comment.
keys: "synchronizable", "accessibility" and "key" are keys internal to Keychain.
Sajjon
reviewed
Nov 9, 2023
| saveDeviceInfo: @escaping SaveDeviceInfo, | ||
| deprecatedLoadDeviceID: @escaping DeprecatedLoadDeviceID, | ||
| deleteDeprecatedDeviceID: @escaping DeleteDeprecatedDeviceID, | ||
| getAllMnemonics: @escaping GetAllMnemonics |
There was a problem hiding this comment.
vendor getAllMnemonics only for DEBUG.
Sajjon
reviewed
Nov 9, 2023
|
|
||
| // MARK: - KeyedMnemonicWithPassphrase | ||
| public struct KeyedMnemonicWithPassphrase: Sendable, Hashable { | ||
| public let factorSourceID: FactorSourceID.FromHash |
There was a problem hiding this comment.
include factorSourceID so that we can delete it.
Sajjon
reviewed
Nov 9, 2023
| } | ||
|
|
||
| static let keychainKeySeparator = ":" |
There was a problem hiding this comment.
used by a new failable init, taking this keychainKey as input and trying to create a FactorSourceID from it.
CyonAlexRDX
commented
Nov 9, 2023
| @@ -417,13 +434,6 @@ public struct ImportOlympiaWalletCoordinator: Sendable, FeatureReducer { | |||
| ) | |||
| ) | |||
|
|
|||
| do { | |||
| try userDefaults.addFactorSourceIDOfBackedUpMnemonic(factorSourceID) | |||
There was a problem hiding this comment.
moved to save AFTER we have successfully saved Factor
CyonAlexRDX
commented
Nov 9, 2023
| _ = try await factorSourcesClient.addPrivateHDFactorSource(.init( | ||
| factorSource: factorSource.factorSource.embed(), | ||
| mnemonicWithPasshprase: factorSource.mnemonicWithPassphrase, | ||
| saveIntoProfile: true | ||
| saveIntoProfile: saveIntoProfile |
There was a problem hiding this comment.
Important bug fix: we should not FAIL to save mnemonic into keychain, just because the FactorSource was known by the profile
GhenadieVP
approved these changes
Nov 13, 2023
…h time of sim as suggested in a blog
CyonAlexRDX
commented
Nov 13, 2023
| @@ -1,2 +1,2 @@ | |||
| SCAN_DEVICE="iPhone 15 Pro Max" | |||
| SCAN_DEVICE="iPhone 15 Pro Max (17.0.1)" | |||
There was a problem hiding this comment.
GhenadieVP
approved these changes
Nov 13, 2023
CyonAlexRDX
merged commit 65097cd
into
ABW-2206_import_mnemonic_from_settings
6 checks passed
CyonAlexRDX
deleted the
ABW-2206_import_mnemonic_from_settings_debug_all_mnemonics
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
N.B. Target branch is not main
trim.578EC817-C16B-49A7-84E2-2608613610D9.MOV