Abw 2598 UI teaks main seed phrase required #918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kugel3
reviewed
Nov 20, 2023
| .textStyle(.sheetTitle) | ||
| .padding(.horizontal, -.small2) |
kugel3
reviewed
Nov 20, 2023
|
|
||
| ScrollView(.vertical, showsIndicators: true) { | ||
| Text("The Radix Wallet always uses a single main “Babylon” seed phrase to generate new Personas and new Accounts (when not using a Ledger device).\n\nIf you do not have access to your previous main seed phrase, you can skip entering it for now. The Radix Wallet will create a new one, which will be used for new Personas and Accounts.\n\nYour old Accounts and Personas will still be listed, but you will have to enter their original seed phrase to use them. Alternatively, you can hide them if you no longer are interested in using them.") | ||
| // we use `.init` to preserve bold attribute of string. | ||
| Text(.init(L10n.RecoverSeedPhrase.Header.subtitleNoMainSeedPhrase)) |
There was a problem hiding this comment.
I would prefer LocalizedStringKey to .init, and a less cryptic comment but you will probably object on the grounds of CI being slow...
There was a problem hiding this comment.
I changed to LocalizedStringKey in 3 files.
There was a problem hiding this comment.
The typechecker and I thank you
kugel3
approved these changes
Nov 20, 2023
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira ABW-2598
Before
After