Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ABW-2656] Deriving Accounts Issues #972

Merged
merged 1 commit into from
Dec 19, 2023
Merged

[ABW-2656] Deriving Accounts Issues #972

merged 1 commit into from
Dec 19, 2023

Conversation

kugel3
Copy link
Contributor

@kugel3 kugel3 commented Dec 19, 2023 •
edited by jira bot
Loading

Jira ticket: ABW-2656

Description

When dismissing the Deriving Accounts scan panel during MARS the user will be stuck on an empty screen.

Video

Dismiss in MARS:

Dismiss.MARS.mp4

Dismiss in OARS:

Dismiss.OARS.mp4

This also seems to fix ABW-2658, I have not been able to reproduce it.

RPReplay_Final1702942093.MP4

PR submission checklist

  • I have tested account to account transfer flow and have confirmed that it works

CyonAlexRDX
CyonAlexRDX approved these changes Dec 19, 2023
View reviewed changes
Copy link
Contributor

@CyonAlexRDX CyonAlexRDX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kugel3 kugel3 merged commit 9f67950 into main Dec 19, 2023
6 checks passed
@kugel3 kugel3 deleted the ABW-2656_Deriving-accounts-panel branch December 19, 2023 09:05
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CyonAlexRDX CyonAlexRDX CyonAlexRDX approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kugel3 @CyonAlexRDX