-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ABW-3465] Decode deep link and download metadata #180
Merged
Merged
Changes from 1 commit
Commits
Show all changes
85 commits
Select commit
Hold shift + click to select a range
d3cde8b
HKDF key agreement
GhenadieVP c30ac72
wip
GhenadieVP 009c20e
wip
GhenadieVP a81a3b8
wip
GhenadieVP b2eb4d0
wip
GhenadieVP db36c21
wip
danvleju-rdx 8aab5f5
rename to key_agreement
GhenadieVP 7b40d1e
rename keys
GhenadieVP c1a2216
Add SymmetricKey
GhenadieVP 95e72aa
compare by public key
GhenadieVP 2042513
move hkdf
GhenadieVP 0fbcec0
Fix hkdf ref
GhenadieVP 1b6b418
update link_request
GhenadieVP eeb44cd
wip
GhenadieVP ff8b32e
[ABW-3208] Callback_path fetching (#159)
jakub-rdx 4560409
wip
danvleju-rdx 66ee8d8
wip
GhenadieVP 56c7b57
wip
GhenadieVP ee32831
Merge branch 'main' into rcm_linking
GhenadieVP e98055d
update parser
GhenadieVP 03a7cea
export
GhenadieVP 645aaa3
wip
danvleju-rdx 3ea7600
wip
danvleju-rdx 11c6ca4
no hkdf for now
GhenadieVP e1f0bd7
change WalletInteractionId from UUID to String
danvleju-rdx 03c7032
Revert "wip"
danvleju-rdx 1daf79f
Merge branch 'main' into ABW-3230-use-wallet-interaction-models-from-…
danvleju-rdx c13ea5e
wip
GhenadieVP ba91c39
wip
GhenadieVP 4d62681
Merge remote-tracking branch 'origin/ABW-3230-use-wallet-interaction-…
GhenadieVP 9e77d70
wip
GhenadieVP 41dcb77
request in deepLink
GhenadieVP 944c2a0
Implement RadixConnectSessionStorage for kotlin (#163)
micbakos-rdx bd34a56
Expose kotlin serde for RadixConnectMobileLinkRequest (#164)
micbakos-rdx 8842991
request in deepLink URL
GhenadieVP 2774460
Optional request body for `GET` methods (#165)
micbakos-rdx f99a4df
wip
GhenadieVP e4a933a
Merge branch 'rcm_linking' of https://github.com/radixdlt/sargon into…
GhenadieVP 696136f
Merge branch 'main' into rcm_linking
GhenadieVP cdbc6da
wip
GhenadieVP 88b947b
Redo PR #164 since some methods of `RadixConnectMobileLinkRequest` we…
micbakos-rdx 7483c16
Merge branch 'main' into rcm_linking
GhenadieVP 855edf9
wip
GhenadieVP 24f5cd0
signature validation
GhenadieVP 9fde320
wip
GhenadieVP e18ac17
wip
GhenadieVP f5c5bcf
wip
GhenadieVP 94132fb
wip
GhenadieVP 6778672
Merge branch 'main' into rcm_linking
GhenadieVP b7ddec5
hkdf
GhenadieVP 27da157
wip
GhenadieVP 16a2691
update parse_url_into_request test
danvleju-rdx 981a249
tests
danvleju-rdx e9509a4
tests
danvleju-rdx 5e35944
wip
sergiupuhalschi-rdx 83950f0
Merge branch 'main' into mb/af-dl
matiasbzurovski f8ca099
WIP
matiasbzurovski 32bf160
WIP
matiasbzurovski b8fe839
Add tests
matiasbzurovski 32ff810
Updates
matiasbzurovski 9deeede
Merge main
sergiupuhalschi-rdx ce8c80b
Revert changes after merge
sergiupuhalschi-rdx 74c5315
Add cards manager. Update mod structure
sergiupuhalschi-rdx f76160e
Rename cards
sergiupuhalschi-rdx 52c59ee
Updates to model and logic
matiasbzurovski 15f727c
Add parser struct
matiasbzurovski 2d13af8
WIP add metadata support
matiasbzurovski f917270
Logic to fetch metadata
matiasbzurovski 4f944a3
Merge branch 'main' into mb/deferred-parsing
matiasbzurovski b572e9e
Bump
matiasbzurovski 5c99851
Lint
matiasbzurovski dcf9795
Remove connector card from parser
matiasbzurovski 23871a1
Implement home cards manager
sergiupuhalschi-rdx 3c114a7
Implement home cards ordering
sergiupuhalschi-rdx 2272670
Add home cards manager init for new wallet function
sergiupuhalschi-rdx ab3570f
Changes after feedback
matiasbzurovski 2f8a090
Rename exposed functions
sergiupuhalschi-rdx 7b025ea
changes after feedback
matiasbzurovski e187b29
Expose home cards manager in kt
sergiupuhalschi-rdx a3479e8
Version bump
sergiupuhalschi-rdx 2d50937
Replace StartRadQuest card after resolving DL if needed. Update defau…
sergiupuhalschi-rdx 0527ee2
Update API
sergiupuhalschi-rdx 4af5f0e
Address PR comment
sergiupuhalschi-rdx 9021fdc
Version bump
sergiupuhalschi-rdx c54e8b2
Merge branch 'main' into mb/deferred-parsing
sergiupuhalschi-rdx File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm, this does not seem to be possible - by definition this function should be called only after user did install the wallet, so there cannot be
StartRadQuest
stored.Rather, it is the other way around - in
wallet_created
, we should not add theHomeCard::StartRadQuest
ifHomeCard::ContinueRadQuest
is already present.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right. What about keeping this logic in both methods to make sure there is no chance both
StartRadQuest
andContinueRadQuest
are present at the same time? This way Sargon won't care about the order of the method calls. Also, for the deep link to be resolved the AF SDK performs a network request, then we perform a network request for the dApp icon URL, so there is a tiny possibility the deep link won't be handled fast enough. Keeping this logic also would prevent any scenarios like this.