Hidden resources kt extesions #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## ABW-3712-hidden-resources #200 +/- ##
=========================================================
Coverage 97.3% 97.4%
=========================================================
Files 920 921 +1
Lines 14714 14727 +13
Branches 64 64
=========================================================
+ Hits 14325 14346 +21
+ Misses 382 374 -8
Partials 7 7
Flags with carried forward coverage won't be shown. Click here to find out more.
|
sergiupuhalschi-rdx
added
the
Coverage OK ☂️ ✅
| @@ -46,7 +46,6 @@ android { | |||
| java.srcDir("${buildDir}/generated/src/release/java") | |||
| } | |||
| } | |||
| packaging { resources.excludes.add("META-INF/*") } | |||
There was a problem hiding this comment.
This fixed the issue of kotlin extensions not being visible.
There was a problem hiding this comment.
Great! @GhenadieVP @micbakos-rdx i think Michael said that Ghenadie added it.
Any good reason for adding it Ghenadie?
Michael did your linking issues get fixed when you tried removing this?
matiasbzurovski
approved these changes
Aug 16, 2024
sergiupuhalschi-rdx
merged commit b374c20
into
ABW-3712-hidden-resources
12 checks passed
matiasbzurovski
added a commit
that referenced
this pull request
Aug 16, 2024
* Changes to AppPreferences with commented tests * WIP * get all hidden resources * fix tests * WIP * WIP * bump version * add flag to Security * uncomment test * WIP * fixes * fix iOS Tests * Add bool type macro and use it for Security flags * move macro to its own file * missing tests and docs * Hidden resources kt extesions (#200) * Add kt extensions for resource preferences * Remove packaging option * Update asset preferences kt extensions * revert JSON changes --------- Co-authored-by: sergiupuhalschi-rdx <164897324+sergiupuhalschi-rdx@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.