-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hidden resources kt extesions #200
Hidden resources kt extesions #200
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## ABW-3712-hidden-resources #200 +/- ##
=========================================================
Coverage 97.3% 97.4%
=========================================================
Files 920 921 +1
Lines 14714 14727 +13
Branches 64 64
=========================================================
+ Hits 14325 14346 +21
+ Misses 382 374 -8
Partials 7 7
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -46,7 +46,6 @@ android { | |||
java.srcDir("${buildDir}/generated/src/release/java") | |||
} | |||
} | |||
packaging { resources.excludes.add("META-INF/*") } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This fixed the issue of kotlin extensions not being visible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! @GhenadieVP @micbakos-rdx i think Michael said that Ghenadie added it.
Any good reason for adding it Ghenadie?
Michael did your linking issues get fixed when you tried removing this?
b374c20
into
ABW-3712-hidden-resources
* Changes to AppPreferences with commented tests * WIP * get all hidden resources * fix tests * WIP * WIP * bump version * add flag to Security * uncomment test * WIP * fixes * fix iOS Tests * Add bool type macro and use it for Security flags * move macro to its own file * missing tests and docs * Hidden resources kt extesions (#200) * Add kt extensions for resource preferences * Remove packaging option * Update asset preferences kt extensions * revert JSON changes --------- Co-authored-by: sergiupuhalschi-rdx <164897324+sergiupuhalschi-rdx@users.noreply.github.com>
No description provided.