Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Intent/SignedIntent Hash formatted method #56

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

micbakos-rdx
Copy link
Contributor

@micbakos-rdx micbakos-rdx self-assigned this Apr 3, 2024
Copy link
Contributor

@CyonAlexRDX CyonAlexRDX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Good job!

Copy link

codecov bot commented Apr 3, 2024

Codecov Report

Attention: Patch coverage is 95.65217% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 99.2%. Comparing base (2e55016) to head (33a2043).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop     #56     +/-   ##
=========================================
- Coverage     99.2%   99.2%   -0.1%     
=========================================
  Files          420     420             
  Lines         7508    7529     +21     
  Branches         4       4             
=========================================
+ Hits          7455    7475     +20     
- Misses          53      54      +1     
Flag Coverage Δ
kotlin 100.0% <100.0%> (ø)
rust 99.1% <94.1%> (-0.1%) ⬇️
swift 99.7% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
.../java/com/radixdlt/sargon/extensions/IntentHash.kt 100.0% <100.0%> (ø)
...com/radixdlt/sargon/extensions/SignedIntentHash.kt 100.0% <100.0%> (ø)
...low_level/transaction_hashes/transaction_hashes.rs 96.7% <94.1%> (-1.1%) ⬇️

@micbakos-rdx micbakos-rdx merged commit b78ff0a into develop Apr 3, 2024
8 of 10 checks passed
@micbakos-rdx micbakos-rdx deleted the intent-signed-intent-format branch April 3, 2024 10:03
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants