Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use IntervalSets.jl intervals in extents #29

Open
rafaqz opened this issue Sep 19, 2024 · 5 comments
Open

Use IntervalSets.jl intervals in extents #29

rafaqz opened this issue Sep 19, 2024 · 5 comments

Comments

@rafaqz
Copy link
Owner

rafaqz commented Sep 19, 2024 •
edited
Loading

This rasterization bug is cause by raster extents being closed, open and polygon extents being closed, closed, but using them both in the same methods:

rafaqz/Rasters.jl#749

I can fix this in rasters by hacking in upper + eps(upper) for the extent. But it could be good to fix this more comprehensively.

@asinghvi17
@asinghvi17
Copy link

IntervalSets brings in Random, Statistics and RecipesBase - so I'm not sure whether it's suitable as a dependency of GeoInterface...

Maybe we improvise something here?

@rafaqz
Copy link
Owner Author

rafaqz commented Sep 19, 2024

Ugh thats unfortunate. But maybe we can make all of those extensions in IntervalSets?

@rafaqz
Copy link
Owner Author

rafaqz commented Sep 19, 2024

Its already done! theyre extensions. So its no problem

@asinghvi17
Copy link

Perfect, as long as they can switch to Julia v1.9 compat we should be golden!

@rafaqz
Copy link
Owner Author

rafaqz commented Sep 19, 2024

Ah right we are still on 1.5 here. We can bump to 1.10 very soon hopefully

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rafaqz @asinghvi17