rasterize is not covering the full extent of the input polygon

[asinghvi17]

MWE:
california_borders.geojson.txt

using GeoJSON, Rasters, CairoMakie
california_borders = GeoJSON.read(read("california_borders.geojson.txt"))
raster = rasterize(california_borders; fill = 1, res = 0.5, shape = :line)

fig, ax, plt = plot(raster; colormap = cgrad(:Set3; categorical = true))
lines!(ax, california_borders; color = :darkgrey, linewidth = 1)
scatter!(ax, vec(DimPoints(raster)); markersize = 3, color = :black)
fig

Note here that the top seems uncovered by the raster?! Also it's not closed.

[rafaqz]

Ahh right it needs to use Touches for the extent somewhere.

And the plotting looks a bit weird too, like there is a half offset missing somewhere.

[rafaqz]

Uggh this is an open/closed intervals problem. Probably I should actually use Interval internally to fix it cleanly.

Like the extent of a polygon is closed,closed but a raster is closed,open. So we are missing the points at the edges

[rafaqz]

Adding eps to upper bounds fixes it. I think I consolodated a bunch of separate code at some point in the past and broke it by treating all extents as the same. Maybe extents should hold intervals...

[asinghvi17]

Gotcha, looks like a doable fix then..

[rafaqz]

Yeah the qustion is if we fix it here or in Extents.jl.

Maybe Intervals in extents is a longer term problem, and I'll hack it here for now.

[rafaqz]

Ok this looks accurate to me now, as this DimPoints is the starts of the intervals

[asinghvi17]

Sweet!

Should DimPoints be defined as always being the center of the interval? Is there a way one can specify that?

[rafaqz]

Yeah, hard to say. Despite the name it knows that its still Intervals{Start} and that will e.g. propagate through similar, broadcasts etc. Its just giving you the values in the lookups as points so changing them might be confusing.