introduce specialized view for rails 8 authentication generator #384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flavorjones
force-pushed
the
flavorjones-add-sessions-template
branch
from
acdd45a
to
f92f025
Compare
flavorjones
force-pushed
the
flavorjones-add-sessions-template
branch
from
6ecee01
to
9de846b
Compare
Co-authored-by: yshmarov <yshmarov@gmail.com>
because the authentication template is only on rails edge
flavorjones
force-pushed
the
flavorjones-add-sessions-template
branch
from
9de846b
to
381446b
Compare
|
@yshmarov Can you give this a try before I merge it? |
|
We should expand this to also cover the new password reset flow that landed on rails/main. |
|
Good to go! |
Looks good 
|
|
Thanks all! Merged. Will cut a release shortly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependent on rails/rails#52442
Closes #382
Co-authored by @yshmarov