harden typing to increase safety of serialization routine #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #81 +/- ##
==========================================
- Coverage 75.26% 75.23% -0.03%
==========================================
Files 18 18
Lines 857 856 -1
==========================================
- Hits 645 644 -1
Misses 212 212
☔ View full report in Codecov by Sentry. |
ralexstokes
commented
Jun 23, 2023
ssz-rs/src/ser.rs
Outdated
Comment on lines
85
to
86
| let bytes_written = running_length.serialize(buffer)?; | ||
| debug_assert_eq!(bytes_written, BYTES_PER_LENGTH_OFFSET); |
There was a problem hiding this comment.
this kind of just moves the problem elsewhere but we could change the defn of Part:
enum Part {
Fixed(Vec<u8>),
Offset(u32),
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
minor but also skips a redundant iteration over the variable lengths summation that can be done inline like the fixed lengths summation