Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error on extra input when deserializing Union[None] for some SSZ union type #83

Merged
merged 1 commit into from
Jul 8, 2023

Conversation

ralexstokes
Copy link
Owner

discovered in the Oak Security audit

Excess bytes in the encoding of None do not trigger errors

@codecov
Copy link

codecov bot commented Jun 27, 2023

Codecov Report

Patch coverage: 66.66% and project coverage change: +0.02 🎉

Comparison is base (b872969) 75.26% compared to head (39d1bb7) 75.29%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #83      +/-   ##
==========================================
+ Coverage   75.26%   75.29%   +0.02%     
==========================================
  Files          18       18              
  Lines         857      862       +5     
==========================================
+ Hits          645      649       +4     
- Misses        212      213       +1     
Impacted Files Coverage Δ
ssz-rs/src/union.rs 56.66% <66.66%> (+4.66%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ralexstokes ralexstokes added this to the v1.0 milestone Jun 27, 2023
@ralexstokes ralexstokes merged commit 197c460 into main Jul 8, 2023
4 of 5 checks passed
@ralexstokes ralexstokes deleted the address-option branch July 8, 2023 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant