Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Indexed trait to compute generalized indices #88

Closed
wants to merge 3 commits into from

Conversation

ralexstokes
Copy link
Owner

@ralexstokes ralexstokes commented Jun 30, 2023

part I of adding multiproofs:

adds an Indexed trait so types can compute their own generalized indices from statically defined paths into each SSZ data structure

and pulls in earlier multiproof code from #2.

TODO:

  • double-check implementation and things we support (e.g. no recursive custom types for now)
  • port Container and Union implementations to proc derive macro

@ralexstokes ralexstokes added this to the v1.0 milestone Jun 30, 2023
@codecov
Copy link

codecov bot commented Jun 30, 2023

Codecov Report

Patch coverage has no change and project coverage change: -9.58 ⚠️

Comparison is base (e37de56) 75.29% compared to head (9977e20) 65.71%.

❗ Current head 9977e20 differs from pull request most recent head 21ae1a8. Consider uploading reports for the commit 21ae1a8 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #88      +/-   ##
==========================================
- Coverage   75.29%   65.71%   -9.58%     
==========================================
  Files          18       21       +3     
  Lines         858      983     +125     
==========================================
  Hits          646      646              
- Misses        212      337     +125     
Impacted Files Coverage Δ
ssz-rs/src/boolean.rs 77.77% <0.00%> (-13.53%) ⬇️
ssz-rs/src/lib.rs 100.00% <ø> (ø)
ssz-rs/src/list.rs 65.85% <0.00%> (-8.12%) ⬇️
ssz-rs/src/merkleization/mod.rs 93.10% <ø> (ø)
...src/merkleization/multiproofs/generalized_index.rs 0.00% <0.00%> (ø)
ssz-rs/src/merkleization/multiproofs/indexed.rs 0.00% <0.00%> (ø)
ssz-rs/src/merkleization/multiproofs/mod.rs 0.00% <0.00%> (ø)
ssz-rs/src/uint.rs 80.00% <0.00%> (-8.32%) ⬇️
ssz-rs/src/vector.rs 76.13% <0.00%> (-6.58%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ralexstokes ralexstokes mentioned this pull request Jun 30, 2023
@ralexstokes
Copy link
Owner Author

something to check out: https://github.com/lightclient/proof

@ralexstokes
Copy link
Owner Author

closing in lieu of #120

@ralexstokes ralexstokes deleted the compile-time-gi branch March 30, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant