Skip to content

Commit

Permalink
Reviewdog pre-submit fixes (slsa-framework#214)
Browse files Browse the repository at this point in the history
* fix yamllint config

* Extend default

* ADd test file

* add back comment

* fix config path

* add permissions to reviewdog pre-submit

* set pr-review reporter

* Update reporter

* Fix secret

* use pull_request_target

* Remove test file

* Don't allow PR comments.
  • Loading branch information
ianlewis committed Jun 9, 2022
1 parent 87c769e commit 4950c68
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 3 deletions.
9 changes: 7 additions & 2 deletions .github/workflows/pre-submit.reviewdog.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
name: reviewdog
on: [pull_request]

"on": [pull_request]

# TODO(github.com/slsa-framework/slsa-github-generator/issues/228): use more restrictive default
permissions: read-all

jobs:
golangci-lint:
runs-on: ubuntu-latest
Expand Down Expand Up @@ -37,6 +42,6 @@ jobs:
- name: yamllint
uses: reviewdog/action-yamllint@v1
with:
yamllint_flags: "-c .yamllint.config.yaml ."
yamllint_flags: "-c .yamllint.yaml ."
level: warning
fail_on_error: true
5 changes: 4 additions & 1 deletion .yamllint.config.yaml → .yamllint.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
---
extends: default

rules:
line-length: disable
comments:
# prettier formats comments one space from content
min-spaces-from-content: 1
document-start: disable
line-length: disable

0 comments on commit 4950c68

Please sign in to comment.