-
-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implements the device authorisation flow #114
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adds support for OAuth 2.0 Device Authorization Grant * Updates `core/mod.rs` to include the new `CoreDeviceAuthorizationResponse` type * Updates `lib.rs` to provide access to `DeviceAuthorizationUrl` and `DeviceAuthorizationRequest` types * Adds `set_device_authorization_uri` method to the `Client` API to set the URL for contacting the device authorization endpoint * Implements an example that showcases the process of using the device grant flow to obtain an ID token from the Okta provider. The example demonstrates device code exchange for an access token. Solves ramosbugs#113
Codecov Report
@@ Coverage Diff @@
## main #114 +/- ##
==========================================
- Coverage 73.92% 73.43% -0.49%
==========================================
Files 17 17
Lines 4092 4107 +15
==========================================
- Hits 3025 3016 -9
- Misses 1067 1091 +24
|
ramosbugs
reviewed
Jun 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the PR!
@ramosbugs thanks for the review!
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
core/mod.rs
to include the newCoreDeviceAuthorizationResponse
typelib.rs
to provide access toDeviceAuthorizationUrl
andDeviceAuthorizationRequest
typesset_device_authorization_uri
method to theClient
API to set the URL for contacting the device authorization endpointSolves #113