automation: rke1 cluster prov aws #10644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yonasberhe23
force-pushed
the
rke1_cluster_prov_aws
branch
2 times, most recently
from
48440ee
to
baacbd7
Compare
yonasberhe23
force-pushed
the
rke1_cluster_prov_aws
branch
2 times, most recently
from
7db8c26
to
854d030
Compare
richard-cox
requested changes
Apr 2, 2024
| @@ -1,6 +1,6 @@ | |||
| import PagePo from '@/cypress/e2e/po/pages/page.po'; | |||
| import EmberSortableTablePo from '@/cypress/e2e/po/components/ember/ember-sortable-table.po'; | |||
| import EmberModalAddNodeTemplatePo from '@/cypress/e2e/po/components/ember/ember-modal-add-node-template.po'; | |||
| import EmberModalAddNodeTemplatePo from '@/cypress/e2e/po/components/ember/ember-modal-add-node-template-aws.po'; | |||
There was a problem hiding this comment.
There probably needs to be a split here.
This is a generic file handling all providers. The add-node-template one is now provider specific
There was a problem hiding this comment.
ah good call out! will update that
yonasberhe23
force-pushed
the
rke1_cluster_prov_aws
branch
from
854d030
to
210cccd
Compare
richard-cox
approved these changes
Apr 4, 2024
yonasberhe23
force-pushed
the
rke1_cluster_prov_aws
branch
from
5a5518f
to
7c42002
Compare
added 8 commits
April 4, 2024 17:56
yonasberhe23
force-pushed
the
rke1_cluster_prov_aws
branch
from
7c42002
to
46b32a7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #
rancher/qa-tasks#747
Technical notes summary
bugs that cause this test to fail:
Checklist