Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit tests for etcd banner fix #10692

Merged
merged 2 commits into from
Mar 28, 2024
Merged

Add unit tests for etcd banner fix #10692

merged 2 commits into from
Mar 28, 2024

Conversation

nwmac
Copy link
Member

@nwmac nwmac commented Mar 25, 2024 •
edited
Loading

This PR adds a unit test for this issue: #10172, PR: #10173

This should avoid that issue to be manually tested.

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

@nwmac nwmac added this to the v2.9.0 milestone Mar 25, 2024
@nwmac nwmac self-assigned this Mar 25, 2024
mantis-toboggan-md
mantis-toboggan-md requested changes Mar 26, 2024
View reviewed changes
Copy link
Member

@mantis-toboggan-md mantis-toboggan-md left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new unit tests look fine, but there is a lot of other stuff in this PR

@nwmac nwmac force-pushed the add-unit-tests-for-etcd-banner branch from 4d5c2db to dde2f97 Compare March 27, 2024 09:31
@nwmac
Copy link
Member Author

nwmac commented Mar 27, 2024

@mantis-toboggan-md Thanks - not sure what happened there - I've rebased and looks okay now.

@nwmac nwmac merged commit 0770ab7 into rancher:master Mar 28, 2024
25 checks passed
@nwmac nwmac deleted the add-unit-tests-for-etcd-banner branch March 28, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mantis-toboggan-md mantis-toboggan-md mantis-toboggan-md approved these changes

Assignees

@nwmac nwmac

Labels
None yet
Projects
None yet
Milestone
v2.9.0
Development

Successfully merging this pull request may close these issues.
2 participants
@nwmac @mantis-toboggan-md