-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace nuxt-link
with router-link
#10716
Replace nuxt-link
with router-link
#10716
Conversation
`nuxt-link` will be removed from Dashboard and will print a deprecation warning when it is used. Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
nuxt-link
with router-link
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As long as tests pass this LGTM.
Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you covered everything, but please wait for @torchiaf about Harvester, otherwise this will get reverted anyway.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Harvester router seems to be working correctly.
If possible, I would remove the warning message when loading Harvester.
LGTM
@torchiaf can you expand on why we would want to make an exception for Harvester? If we are flagging features as deprecated in v2.9 of Dashboard, would we not want to warn all extension authors that this will break in later versions after said features are removed? |
In general, I think you are right, Anyway, this is really a non-issue I think, that's why I approved it; sorry, I was a little pedantic here 😃 |
Summary
This removes the
NuxtLink
&NLink
components from Dashboard. If an extension or outside component attempts to useNuxtLink
orNLink
, a deprecation warning should print to the console androuter-link
will be used instead.Technical notes summary
I'm attempting to make this change in a way that will be more backwards compatible with extensions that might relay on
NuxtLink
orNLink
. This is done by replacing theNuxtLink
component with an alias that will print a deprecation warning in the console.Areas or cases that should be tested
This affects all routing throughout dashboard.
Checklist