Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix storage class not being selected properly #10808

Merged
merged 8 commits into from
Apr 18, 2024

Conversation

momesgin
Copy link
Member

@momesgin momesgin commented Apr 15, 2024

Summary

Fixes #10765

The current logic pre-selects the storage class if a default storage class exists(i.e. it has annotations: {'storageclass.kubernetes.io/is-default-class': 'true'}) and no storage class is already set. Two scenarios needed to be addressed:

  1. You've saved a storage class different from the default one and are currently viewing it
  2. During editing, you've selected a storage class and switched tabs

Areas or cases that should be tested

In the summary^.

Areas which could experience regressions

n/a

Screenshot/Video

10765.mov

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

@momesgin momesgin added this to the v2.9.0 milestone Apr 16, 2024
@momesgin momesgin marked this pull request as ready for review April 16, 2024 22:12
@momesgin momesgin changed the title fix storage class not being selected properly Fix storage class not being selected properly Apr 16, 2024
Copy link
Member

@rak-phillip rak-phillip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@momesgin momesgin merged commit 1b1b2d2 into rancher:master Apr 18, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Charts: Rancher Backups: Default storage class no longer auto-selected when user leaves page
2 participants