Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EKS - fix secrets encryption with KMS key checkbox #11576

Merged
merged 2 commits into from
Aug 2, 2024

Conversation

mantis-toboggan-md
Copy link
Member

Summary

Fixes #11558

Occurred changes and/or fixed issues

This PR updates the EKS provisioning form to set eksConfig.secretsEncryption when the 'Encrypt Secrets with a KMS key' checkbox is checked.

Areas or cases that should be tested

  1. Create an EKS cluster, check the 'Encrypt secrets' checkbox and select a key. Verify that the save request includes eksConfig.secrets.Encryption: true
  2. Wait for the cluster to provision; edit the cluster and verify that the kms key arn is shown in the form ,but is not editable

Screenshot/Video

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

@mantis-toboggan-md mantis-toboggan-md added this to the v2.10.0 milestone Aug 1, 2024
@mantis-toboggan-md mantis-toboggan-md changed the title Fix eks kms EKS - fix secrets encryption with KMS key checkbox Aug 1, 2024
Copy link
Member

@jordojordo jordojordo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mantis-toboggan-md mantis-toboggan-md merged commit a81d838 into rancher:master Aug 2, 2024
31 checks passed
nwmac pushed a commit to nwmac/dashboard that referenced this pull request Aug 13, 2024
* fix kms key checkbox

* add kms key input unit tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v2.9: KMS key secrets encryption not being set on cluster after provisioning
2 participants