Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Automation] - Additional user retention settings tests #11688

Merged
merged 1 commit into from
Sep 23, 2024
Merged

[Automation] - Additional user retention settings tests #11688

merged 1 commit into from
Sep 23, 2024
+103 −3

Conversation

izaac
Copy link
Contributor

@izaac izaac commented Aug 23, 2024 •
edited
Loading

Summary

Fixes rancher/qa-tasks#1400

Occurred changes and/or fixed issues

Adding new scenarios to the user retention test automation suite.

Technical notes summary

The account has the Disable After and Delete After enabled.
Checking a standard user can't access the Retention settings.

Areas or cases that should be tested

Automation of User retention settings
CI execution

Areas which could experience regressions

Jenkins/GA

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

@izaac izaac added area/authentication QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this labels Aug 23, 2024
@izaac izaac added this to the v2.10.0 milestone Aug 23, 2024
@izaac izaac self-assigned this Aug 23, 2024
@izaac izaac force-pushed the user_retention_cases branch 6 times, most recently from dcce55b to fd3a5d6 Compare August 26, 2024 21:55
@izaac izaac force-pushed the user_retention_cases branch 3 times, most recently from c749501 to a60802e Compare August 27, 2024 14:49
@yonasberhe23 yonasberhe23 self-requested a review August 27, 2024 15:52
yonasberhe23
yonasberhe23 previously approved these changes Aug 27, 2024
View reviewed changes
@izaac
Copy link
Contributor Author

izaac commented Aug 27, 2024 •
edited
Loading

I'll revisit this implementation as it's no longer applicable on master as the settings are now dependent of auth-user-session-ttl-minutes cc @yonasberhe23

@izaac izaac marked this pull request as draft August 27, 2024 18:15
@izaac izaac force-pushed the user_retention_cases branch 6 times, most recently from bb166fb to 0b7dc18 Compare September 13, 2024 16:55
@izaac izaac marked this pull request as ready for review September 13, 2024 22:06
yonasberhe23
yonasberhe23 reviewed Sep 20, 2024
View reviewed changes
Copy link
Contributor

@yonasberhe23 yonasberhe23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@izaac izaac merged commit d29392f into rancher:master Sep 23, 2024
30 checks passed
@izaac izaac deleted the user_retention_cases branch September 23, 2024 15:39
@izaac
Copy link
Contributor Author

izaac commented Sep 23, 2024

Linked issue: rancher/rancher#46795

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yonasberhe23 yonasberhe23 yonasberhe23 approved these changes

Assignees

@izaac izaac

Labels
area/authentication QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this
Projects
None yet
Milestone
v2.10.0
Development

Successfully merging this pull request may close these issues.

[UI] Expand on existing User Retention Settings e2e tests
2 participants
@izaac @yonasberhe23