Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vue 3: Fixed describe resource not working #11903

Merged
merged 2 commits into from
Sep 13, 2024

Conversation

eva-vashkevich
Copy link
Member

@eva-vashkevich eva-vashkevich commented Sep 12, 2024

Summary

Fixes #11699

Vue.extend is not available in Vue3 and the result of our migration script didn't work.

Occurred changes and/or fixed issues

Changed the component following https://v3-migration.vuejs.org/breaking-changes/global-api

Technical notes summary

Areas or cases that should be tested

Describe resource should work for all pages that have it as an action

Areas which could experience regressions

None

Screenshot/Video

Screenshot 2024-09-12 at 9 32 00 AM

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

@eva-vashkevich eva-vashkevich merged commit ab2f0a6 into rancher:master Sep 13, 2024
31 checks passed
@eva-vashkevich eva-vashkevich deleted the iss11699 branch September 13, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vue3: Clicking on Describe Resource throws unhandled exception
2 participants