Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure we check for correct status code when testing cli download links #11941

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

richard-cox
Copy link
Member

Summary

Fixes #

Occurred changes and/or fixed issues

  • In v2.9-head the links the UI uses to provide the download cli links will soon be updated to 2.9.2
  • Those links though are dead and won't exist until after 2.9.2 is released
  • In the short term check that they're dead
  • Note 1 - Once they're fixed we'll know, as the e2e tests will start failing
  • Note 2 - This will fail until v2.9-head changes merge and build happens. We can force merge if needs be

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

@richard-cox richard-cox added this to the v2.9.2 milestone Sep 17, 2024
@richard-cox richard-cox self-assigned this Sep 17, 2024
@richard-cox richard-cox merged commit 3283c99 into rancher:release-2.9 Sep 18, 2024
26 checks passed
@richard-cox richard-cox deleted the cli-download-e2e branch September 18, 2024 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants