Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logging flow rules #11944

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

rak-phillip
Copy link
Member

@rak-phillip rak-phillip commented Sep 17, 2024

Summary

This resolves an issue with adding a include / exclude pod card to the list when creating a new flow for the logging chart.

Fixes #11933

Occurred changes and/or fixed issues

  • replace set() usage with assignment
  • create a new array to ensure that reactivity is triggered for matches

Technical notes summary

We encountered a similar issue related to using push that was resolved in #11788

Areas or cases that should be tested

  • Logging (see issue description)

Areas which could experience regressions

  • Logging (see issue description)

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
@rancher-ui-project-bot rancher-ui-project-bot bot added this to the v2.10.0 milestone Sep 17, 2024
@rak-phillip rak-phillip marked this pull request as ready for review September 17, 2024 23:22
@rak-phillip rak-phillip changed the title Bugfix/11933 flow rules Fix logging flow rules Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Logging: Unable to add include or exclude rules when creating an Flow
2 participants