Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#593 add password requirements #1208

Merged
merged 17 commits into from
Apr 15, 2024

Conversation

martyav
Copy link
Contributor

@martyav martyav commented Apr 1, 2024

Fixes #593

Reminders

  • See the README for more details on how to work with the Rancher docs.

  • Verify if changes pertain to other versions of Rancher. If they do, finalize the edits on one version of the page, then apply the edits to the other versions.

  • If the pull request is dependent on an upcoming release, make sure to target the release branch instead of main.

Description

This adds the password requirements to a central location and refreshes the Setting a Bootstrap Password page to use tabs and remove redundant material.

Also: Users are not actually REQUIRED to reset the admin password after first login, though they likely should.

Comments

Backticks don't seem to work inside tabs unless they're at the end of a line or on their own line?

A page in the dashboard repo makes some claims about passwords that I'm trying to verify: https://github.com/rancher/dashboard/blob/master/docusaurus/docs/code-base-works/auth-sessions-and-tokens.md

  1. The minimum password length can be modified by the user (not sure at all if this is relevant to the bootstrap password) This doesn't apply to the bootstrap password. Passwords made later must be 12 chars or longer.
  2. Password and username must differ

@martyav
Copy link
Contributor Author

martyav commented Apr 2, 2024

Re:

  1. Can users alter the minimum password length post-installation?
  2. Is it possible for the user to set up Rancher in such a way that the bootstrap password has a minimum length different from 12 chars?
  3. Are there additional password requirements, such as the username and password must differ?

https://github.com/rancher/dashboard/blob/master/docusaurus/docs/code-base-works/auth-sessions-and-tokens.md from the dashboard repo claims that users can alter the password length with CATTLE_PASSWORD_MIN_LENGTH, but I'm not sure if that field's exposed to users. It also claims the additional requirement that the username and password must differ, which is quite sensible, but wanted to verify.

image

@martyav martyav marked this pull request as ready for review April 2, 2024 17:50
@martyav
Copy link
Contributor Author

martyav commented Apr 2, 2024

@maxsokolovsky Hi, Max. To follow up from this morning, can users alter the minimum length of the admin password (not the special case of the bootstrap -- we have established that it has no min length)? And is there any other validation going on -- for example, requiring that the username and password must differ?

@maxsokolovsky
Copy link
Contributor

@martyav, the only thing I am seeing in the code and an actual test is that the password must be 12 characters in length.

@btat
Copy link
Contributor

btat commented Apr 2, 2024

@martyav This (rancher/dashboard#6633) should be considered as well.

@martyav
Copy link
Contributor Author

martyav commented Apr 2, 2024

Parent issue


Pull requests

Co-authored-by: Lucas Saintarbor <lucas.saintarbor@suse.com>
Set the following value in the Rancher Helm chart:

```yaml
.Values.bootstrapPassword
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line 27 says run the following commands, but this isn't a command.

Is this intended to be a snippet of the values.yaml file or a snippet of the Helm install command? In either case, the syntax is incorrect.

Copy link
Contributor Author

@martyav martyav Apr 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was originally listed inline:

For a Helm install, users can specify the bootstrap password variable by configuring it in the Helm chart values with .Values.bootstrapPassword.

For some reason, the backtick formatting wasn't working inside the tab when I looked at a preview of the site, but using the code block syntax with triple backticks worked

@martyav martyav added the sync-versions Reminder to sync versioned pages label Apr 10, 2024
@martyav martyav requested a review from btat April 11, 2024 14:31
Co-authored-by: Billy Tat <btat@suse.com>
@martyav
Copy link
Contributor Author

martyav commented Apr 15, 2024

Synced with v2.8 to v2.6

@martyav martyav removed the sync-versions Reminder to sync versioned pages label Apr 15, 2024
@martyav martyav merged commit 489b54c into rancher:main Apr 15, 2024
1 check passed
@martyav martyav deleted the 593-add-password-requirements branch April 15, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add password requirements
4 participants