-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#593 add password requirements #1208
Conversation
Re:
|
…uent admin passwords must be 12 chars or longer
@maxsokolovsky Hi, Max. To follow up from this morning, can users alter the minimum length of the admin password (not the special case of the bootstrap -- we have established that it has no min length)? And is there any other validation going on -- for example, requiring that the username and password must differ? |
@martyav, the only thing I am seeing in the code and an actual test is that the password must be 12 characters in length. |
@martyav This (rancher/dashboard#6633) should be considered as well. |
Parent issuePull requests
|
docs/getting-started/installation-and-upgrade/installation-references/helm-chart-options.md
Outdated
Show resolved
Hide resolved
docs/getting-started/installation-and-upgrade/resources/bootstrap-password.md
Outdated
Show resolved
Hide resolved
docs/getting-started/installation-and-upgrade/resources/bootstrap-password.md
Outdated
Show resolved
Hide resolved
docs/getting-started/installation-and-upgrade/resources/bootstrap-password.md
Outdated
Show resolved
Hide resolved
docs/getting-started/installation-and-upgrade/resources/bootstrap-password.md
Outdated
Show resolved
Hide resolved
docs/getting-started/installation-and-upgrade/resources/bootstrap-password.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Lucas Saintarbor <lucas.saintarbor@suse.com>
docs/getting-started/installation-and-upgrade/installation-references/helm-chart-options.md
Outdated
Show resolved
Hide resolved
docs/getting-started/installation-and-upgrade/installation-references/helm-chart-options.md
Outdated
Show resolved
Hide resolved
docs/getting-started/installation-and-upgrade/resources/bootstrap-password.md
Outdated
Show resolved
Hide resolved
docs/getting-started/installation-and-upgrade/resources/bootstrap-password.md
Outdated
Show resolved
Hide resolved
docs/getting-started/installation-and-upgrade/resources/bootstrap-password.md
Outdated
Show resolved
Hide resolved
docs/getting-started/installation-and-upgrade/resources/bootstrap-password.md
Outdated
Show resolved
Hide resolved
Set the following value in the Rancher Helm chart: | ||
|
||
```yaml | ||
.Values.bootstrapPassword |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line 27 says run the following commands
, but this isn't a command.
Is this intended to be a snippet of the values.yaml file or a snippet of the Helm install command? In either case, the syntax is incorrect.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was originally listed inline:
For a Helm install, users can specify the bootstrap password variable by configuring it in the Helm chart values with
.Values.bootstrapPassword
.
For some reason, the backtick
formatting wasn't working inside the tab when I looked at a preview of the site, but using the code block syntax with triple backticks worked
docs/getting-started/installation-and-upgrade/resources/bootstrap-password.md
Outdated
Show resolved
Hide resolved
docs/getting-started/installation-and-upgrade/resources/bootstrap-password.md
Outdated
Show resolved
Hide resolved
…93-add-password-requirements
docs/getting-started/installation-and-upgrade/resources/bootstrap-password.md
Outdated
Show resolved
Hide resolved
docs/getting-started/installation-and-upgrade/resources/bootstrap-password.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Billy Tat <btat@suse.com>
Synced with v2.8 to v2.6 |
Fixes #593
Reminders
See the README for more details on how to work with the Rancher docs.
Verify if changes pertain to other versions of Rancher. If they do, finalize the edits on one version of the page, then apply the edits to the other versions.
If the pull request is dependent on an upcoming release, make sure to target the release branch instead of
main
.Description
This adds the password requirements to a central location and refreshes the Setting a Bootstrap Password page to use tabs and remove redundant material.
Also: Users are not actually REQUIRED to reset the admin password after first login, though they likely should.
Comments
Backticks don't seem to work inside tabs unless they're at the end of a line or on their own line?
A page in the dashboard repo makes some claims about passwords that I'm trying to verify: https://github.com/rancher/dashboard/blob/master/docusaurus/docs/code-base-works/auth-sessions-and-tokens.md
The minimum password length can be modified by the user (not sure at all if this is relevant to the bootstrap password)This doesn't apply to the bootstrap password. Passwords made later must be 12 chars or longer.