Add Cipher_Mode::ideal_granularity #3168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reflects the size that would be best for performance, while update_granularity is modified to return the true minimum value. GH #3163
randombit
force-pushed
the
jack/ideal-granularity
branch
from
47a11f0
to
510a831
Compare
novasharper
reviewed
Jan 10, 2023
Codecov ReportBase: 88.04% // Head: 88.04% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #3168 +/- ##
==========================================
- Coverage 88.04% 88.04% -0.01%
==========================================
Files 604 605 +1
Lines 67226 67347 +121
Branches 6735 6739 +4
==========================================
+ Hits 59192 59298 +106
- Misses 5212 5222 +10
- Partials 2822 2827 +5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
randombit
force-pushed
the
jack/ideal-granularity
branch
from
3ffabe4
to
9f6db46
Compare
randombit
added a commit
that referenced
this pull request
Jan 13, 2023
Previously update_granularity == 1 was an (undocumented and not reliable) method of detecting if an AEAD mode required presenting the entire message before processing could occur. Since #3168 this assumption is no longer valid. Add a method which directly indicates if the cipher mode has this nature.
randombit
added a commit
that referenced
this pull request
Jan 15, 2023
That PR accidentally disabled decrypting multiple blocks in parallel.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reflects the size that would be best for performance, while update_granularity is modified to return the true minimum value.
GH #3163