Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor AlternativeName internals #4034

Merged
merged 4 commits into from
May 10, 2024
Merged

Refactor AlternativeName internals #4034

merged 4 commits into from
May 10, 2024

Commits on May 7, 2024

  1. Refactor AlternativeName internals 

    This provides a completely new and rather more sensible interface,
with the old (now deprecated) interface being implemented in terms
of the new interface.

It also resolves a performance issue when parsing certificates with
many (thousands) of alternative names; previously this triggered
some accidentally quadratic code when checking for duplicates.

Performance issue was reported by Bing Shi.
    @randombit
    randombit committed May 7, 2024
    Configuration menu
    Copy the full SHA
    c6cadc4 View commit details
    Browse the repository at this point in the history

  2. Address some review comments

    @randombit
    randombit committed May 7, 2024
    Configuration menu
    Copy the full SHA
    c4ffa88 View commit details
    Browse the repository at this point in the history

  3. Correct encoding of DNs in SubjectAlternativeName

    @randombit
    randombit committed May 7, 2024
    Configuration menu
    Copy the full SHA
    c0eda69 View commit details
    Browse the repository at this point in the history

Commits on May 8, 2024

  1. Add a test for alt DN encoding

    @randombit
    randombit committed May 8, 2024
    Configuration menu
    Copy the full SHA
    75a0deb View commit details
    Browse the repository at this point in the history