Address denial of service in name constraints processing #4186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Checking a name constraint is quadratic to the number of names and constraints. Place a hard limit on the total number of comparisons. This issue was discovered and reported by Bing Shi. CVE-2024-34702
randombit
force-pushed
the
jack/fix-nc-dos
branch
from
e5a73af
to
655c2be
Compare
randombit
requested review from
FAlbertDev and
reneme
and removed request for
FAlbertDev
FAlbertDev
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checking a name constraint is quadratic to the number of names and constraints. Place a hard limit on the total number of comparisons.
This issue was discovered and reported by Bing Shi.
CVE-2024-34702