Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new SBP coefficients of Diener, Dorband, Schnetter, Tiglio (2007) #129

Merged
merged 3 commits into from
Mar 4, 2022

Conversation

ranocha
Copy link
Owner

@ranocha ranocha commented Mar 4, 2022

Closes #128. This includes the diagonal-norm operators of

@article{diener2007optimized,
  title={Optimized high-order derivative and dissipation operators satisfying
         summation by parts, and applications in three-dimensional multi-block
         evolutions},
  author={Diener, Peter and Dorband, Ernst Nils and Schnetter, Erik and
          Tiglio, Manuel},
  journal={Journal of Scientific Computing},
  volume={32},
  number={1},
  pages={109--145},
  year={2007},
  publisher={Springer},
  doi={10.1007/s10915-006-9123-7}
}

The corresponding dissipation operators follow the recipe of Mattsson, Svärd, Nordström (2004), so they are available via dissipation_operator (up to the scaling epsilon vs. epsilon / 2^accuracy_order).

@codecov
Copy link

codecov bot commented Mar 4, 2022

Codecov Report

Merging #129 (1de347d) into main (21d463f) will decrease coverage by 1.88%.
The diff coverage is 32.25%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #129      +/-   ##
==========================================
- Coverage   91.94%   90.05%   -1.89%     
==========================================
  Files          30       31       +1     
  Lines        4741     4896     +155     
==========================================
+ Hits         4359     4409      +50     
- Misses        382      487     +105     
Flag Coverage Δ
unittests 90.05% <32.25%> (-1.89%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/SummationByPartsOperators.jl 100.00% <ø> (ø)
...P_coefficients/DienerDorbandSchnetterTiglio2007.jl 32.25% <32.25%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21d463f...1de347d. Read the comment docs.

@coveralls
Copy link

coveralls commented Mar 4, 2022

Coverage Status

Coverage decreased (-1.9%) to 90.053% when pulling 1de347d on hr/DienerDorbandSchnetterTiglio2007 into 21d463f on main.

@ranocha ranocha force-pushed the hr/DienerDorbandSchnetterTiglio2007 branch from 58a059b to c98508e Compare March 4, 2022 12:34
@ranocha ranocha marked this pull request as ready for review March 4, 2022 12:35
@ranocha ranocha enabled auto-merge (squash) March 4, 2022 12:35
@ranocha
Copy link
Owner Author

ranocha commented Mar 4, 2022

CC @eschnett

@ranocha ranocha disabled auto-merge March 4, 2022 12:35
@ranocha ranocha enabled auto-merge (squash) March 4, 2022 12:36
@ranocha ranocha disabled auto-merge March 4, 2022 12:36
@ranocha ranocha changed the title WIP: new SBP coefficients of Diener, Dorband, Schnetter, Tiglio (2007) new SBP coefficients of Diener, Dorband, Schnetter, Tiglio (2007) Mar 4, 2022
@ranocha ranocha enabled auto-merge (squash) March 4, 2022 12:37
@ranocha ranocha disabled auto-merge March 4, 2022 13:35
@ranocha ranocha merged commit cc8d95a into main Mar 4, 2022
@ranocha ranocha deleted the hr/DienerDorbandSchnetterTiglio2007 branch March 4, 2022 13:35
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SBP coefficients of Diener, Dorband, Schnetter, Tiglio (2005)
2 participants