Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Sharan, Brady, Livescu 2022 operators #202

Merged
merged 9 commits into from
Jul 23, 2023

Conversation

jlchan
Copy link
Contributor

@jlchan jlchan commented Jul 20, 2023

Adds operators from https://doi.org/10.1016/j.jcp.2022.111341 for cut-cell line domains

@jlchan
Copy link
Contributor Author

jlchan commented Jul 20, 2023

Three higher derivative tests are currently failing locally due to roundoff issues. Since there's a parameter alpha::Float64 involved in the formulas, I am not sure that it is quite as accurate as the other operators.

Any suggestions?

@codecov
Copy link

codecov bot commented Jul 21, 2023

Codecov Report

Merging #202 (c190555) into main (34aaa1e) will decrease coverage by 0.04%.
The diff coverage is 89.53%.

@@            Coverage Diff             @@
##             main     #202      +/-   ##
==========================================
- Coverage   91.63%   91.60%   -0.04%     
==========================================
  Files          35       36       +1     
  Lines        5655     5741      +86     
==========================================
+ Hits         5182     5259      +77     
- Misses        473      482       +9     
Flag Coverage Δ
unittests 91.60% <89.53%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/SummationByPartsOperators.jl 100.00% <ø> (ø)
src/SBP_coefficients/SharanBradyLivescu2022.jl 89.53% <89.53%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

test/SBP_operators_test.jl Outdated Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Jul 21, 2023

Coverage Status

coverage: 91.595% (-0.03%) from 91.627% when pulling c190555 on jlchan:jc/sharan_et_al into 34aaa1e on ranocha:main.

Copy link
Owner

@ranocha ranocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the contribution!

@jlchan jlchan requested a review from ranocha July 21, 2023 13:16
Copy link
Owner

@ranocha ranocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ranocha ranocha merged commit bf0102d into ranocha:main Jul 23, 2023
18 of 20 checks passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants