Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Function space SBP operators #268

Merged
merged 47 commits into from
Jun 14, 2024
Merged

Function space SBP operators #268

merged 47 commits into from
Jun 14, 2024

Commits on May 24, 2024

  1. first draft for function space operators

    @JoshuaLampert
    JoshuaLampert committed May 24, 2024
    Configuration menu
    Copy the full SHA
    d888354 View commit details
    Browse the repository at this point in the history

  2. some spaces

    @JoshuaLampert
    JoshuaLampert committed May 24, 2024
    Configuration menu
    Copy the full SHA
    7fe3217 View commit details
    Browse the repository at this point in the history

  3. order alphabetically

    @JoshuaLampert
    JoshuaLampert committed May 24, 2024
    Configuration menu
    Copy the full SHA
    72e1522 View commit details
    Browse the repository at this point in the history

Commits on May 25, 2024

  1. don't force basis_function to be passed as vector

    @JoshuaLampert
    JoshuaLampert committed May 25, 2024
    Configuration menu
    Copy the full SHA
    5f85d67 View commit details
    Browse the repository at this point in the history

  2. allow passing accuracy_order

    @JoshuaLampert
    JoshuaLampert committed May 25, 2024
    Configuration menu
    Copy the full SHA
    f7a0076 View commit details
    Browse the repository at this point in the history

Commits on May 28, 2024

  1. first (basically) working version

    @JoshuaLampert
    JoshuaLampert committed May 28, 2024
    Configuration menu
    Copy the full SHA
    944046b View commit details
    Browse the repository at this point in the history

  2. orthonormalization via Gram-Schmidt

    @JoshuaLampert
    JoshuaLampert committed May 28, 2024
    Configuration menu
    Copy the full SHA
    18ce612 View commit details
    Browse the repository at this point in the history

  3. add some basic tests

    @JoshuaLampert
    JoshuaLampert committed May 28, 2024
    Configuration menu
    Copy the full SHA
    b576ece View commit details
    Browse the repository at this point in the history

  4. some smaller optimizations

    @JoshuaLampert
    JoshuaLampert committed May 28, 2024
    Configuration menu
    Copy the full SHA
    f3f7208 View commit details
    Browse the repository at this point in the history

  5. fix import of Options

    @JoshuaLampert
    JoshuaLampert committed May 28, 2024
    Configuration menu
    Copy the full SHA
    cd92e53 View commit details
    Browse the repository at this point in the history

  6. another fix...

    @JoshuaLampert
    JoshuaLampert committed May 28, 2024
    Configuration menu
    Copy the full SHA
    8c77cd5 View commit details
    Browse the repository at this point in the history

  7. avoid unnecessary anonymous function

    @JoshuaLampert
    JoshuaLampert committed May 28, 2024
    Configuration menu
    Copy the full SHA
    d62d73b View commit details
    Browse the repository at this point in the history

  8. use version of spzeros that is compatible with older Julia versions

    @JoshuaLampert
    JoshuaLampert committed May 28, 2024
    Configuration menu
    Copy the full SHA
    9d7cc4a View commit details
    Browse the repository at this point in the history

  9. FunctionSpaceOperator -> function_space_operator

    @JoshuaLampert
    JoshuaLampert committed May 28, 2024
    Configuration menu
    Copy the full SHA
    a2ef507 View commit details
    Browse the repository at this point in the history

  10. add proper docstring

    @JoshuaLampert
    JoshuaLampert committed May 28, 2024
    Configuration menu
    Copy the full SHA
    b4b4c7d View commit details
    Browse the repository at this point in the history

  11. extend docstring

    @JoshuaLampert
    JoshuaLampert committed May 28, 2024
    Configuration menu
    Copy the full SHA
    1b67472 View commit details
    Browse the repository at this point in the history

  12. put constructor function in extension

    @JoshuaLampert
    JoshuaLampert committed May 28, 2024
    Configuration menu
    Copy the full SHA
    d4266fe View commit details
    Browse the repository at this point in the history

  13. allow passing options

    @JoshuaLampert
    JoshuaLampert committed May 28, 2024
    Configuration menu
    Copy the full SHA
    1b8d85e View commit details
    Browse the repository at this point in the history

  14. clarify that the operator is of derivative_order 1

    @JoshuaLampert
    JoshuaLampert committed May 28, 2024
    Configuration menu
    Copy the full SHA
    76f7f3f View commit details
    Browse the repository at this point in the history

Commits on May 29, 2024

  1. only Optim has to be loaded

    @JoshuaLampert
    JoshuaLampert committed May 29, 2024
    Configuration menu
    Copy the full SHA
    d52d55c View commit details
    Browse the repository at this point in the history

  2. only for Julia 1.9

    @JoshuaLampert
    JoshuaLampert committed May 29, 2024
    Configuration menu
    Copy the full SHA
    aa868bd View commit details
    Browse the repository at this point in the history

  3. remove fallback imports with Requires

    @JoshuaLampert
    JoshuaLampert committed May 29, 2024
    Configuration menu
    Copy the full SHA
    ad62dcc View commit details
    Browse the repository at this point in the history

Commits on May 30, 2024

  1. use PreallocationTools.jl to reduce allocations

    @JoshuaLampert
    JoshuaLampert committed May 30, 2024
    Configuration menu
    Copy the full SHA
    2144cd1 View commit details
    Browse the repository at this point in the history

  2. add kwarg derivative-order

    @JoshuaLampert
    JoshuaLampert committed May 30, 2024
    Configuration menu
    Copy the full SHA
    29f6830 View commit details
    Browse the repository at this point in the history

Commits on May 31, 2024

  1. add analytical gradient (still much slower than ForwardDiff.jl)

    @JoshuaLampert
    JoshuaLampert committed May 31, 2024
    Configuration menu
    Copy the full SHA
    d4ec79e View commit details
    Browse the repository at this point in the history

  2. fuse function and gradient evaluation

    @JoshuaLampert
    JoshuaLampert committed May 31, 2024
    Configuration menu
    Copy the full SHA
    578a7d2 View commit details
    Browse the repository at this point in the history

  3. avoid some type conversions

    @JoshuaLampert
    JoshuaLampert committed May 31, 2024
    Configuration menu
    Copy the full SHA
    fff300b View commit details
    Browse the repository at this point in the history

  4. use div instead of sum

    @JoshuaLampert
    JoshuaLampert committed May 31, 2024
    Configuration menu
    Copy the full SHA
    9af4c6e View commit details
    Browse the repository at this point in the history

  5. Apply suggestions from code review 

    Co-authored-by: Hendrik Ranocha <ranocha@users.noreply.github.com>
    @JoshuaLampert @ranocha
    JoshuaLampert and ranocha committed May 31, 2024
    Configuration menu
    Copy the full SHA
    540db12 View commit details
    Browse the repository at this point in the history

  6. change order of loops

    @JoshuaLampert
    JoshuaLampert committed May 31, 2024
    Configuration menu
    Copy the full SHA
    c133295 View commit details
    Browse the repository at this point in the history

  7. Update ext/SummationByPartsOperatorsOptimForwardDiffExt.jl 

    Co-authored-by: Hendrik Ranocha <ranocha@users.noreply.github.com>
    @JoshuaLampert @ranocha
    JoshuaLampert and ranocha committed May 31, 2024
    Configuration menu
    Copy the full SHA
    f77df41 View commit details
    Browse the repository at this point in the history

  8. import dot

    @JoshuaLampert
    JoshuaLampert committed May 31, 2024
    Configuration menu
    Copy the full SHA
    519edcd View commit details
    Browse the repository at this point in the history

  9. move optimization_function_and_grad to fix type instability introduce… 

    …d by closure bug
    @ranocha
    ranocha committed May 31, 2024
    Configuration menu
    Copy the full SHA
    feacf4e View commit details
    Browse the repository at this point in the history

  10. move optimization_function_and_grad! outside (that was it!)

    @JoshuaLampert
    JoshuaLampert committed May 31, 2024
    Configuration menu
    Copy the full SHA
    8ebe174 View commit details
    Browse the repository at this point in the history

  11. reolve merge conflict

    @JoshuaLampert
    JoshuaLampert committed May 31, 2024
    Configuration menu
    Copy the full SHA
    b783475 View commit details
    Browse the repository at this point in the history

  12. Update ext/SummationByPartsOperatorsOptimForwardDiffExt.jl 

    Co-authored-by: Hendrik Ranocha <ranocha@users.noreply.github.com>
    @JoshuaLampert @ranocha
    JoshuaLampert and ranocha committed May 31, 2024
    Configuration menu
    Copy the full SHA
    047051b View commit details
    Browse the repository at this point in the history

  13. some cleanups

    @JoshuaLampert
    JoshuaLampert committed May 31, 2024
    Configuration menu
    Copy the full SHA
    0bd5619 View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2024

  1. Merge branch 'main' into FSBP-extension

    @JoshuaLampert
    JoshuaLampert committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    46b15be View commit details
    Browse the repository at this point in the history

  2. ignore stale dependency PreallocationTools in Aqua

    @JoshuaLampert
    JoshuaLampert committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    914cab2 View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2024

  1. add test with non-equidistant nodes

    @JoshuaLampert
    JoshuaLampert committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    1a2a376 View commit details
    Browse the repository at this point in the history

  2. fix test

    @JoshuaLampert
    JoshuaLampert committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    03107f9 View commit details
    Browse the repository at this point in the history

  3. remove kwargs x_min and x_max

    @JoshuaLampert
    JoshuaLampert committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    3e03c73 View commit details
    Browse the repository at this point in the history

  4. add experimental feature warning

    @JoshuaLampert
    JoshuaLampert committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    38081b1 View commit details
    Browse the repository at this point in the history

  5. Update test/matrix_operators_test.jl 

    Co-authored-by: Hendrik Ranocha <ranocha@users.noreply.github.com>
    @JoshuaLampert @ranocha
    JoshuaLampert and ranocha committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    4e9512c View commit details
    Browse the repository at this point in the history

  6. remove l_hat2 since it this case is impossible

    @JoshuaLampert
    JoshuaLampert committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    fd470ee View commit details
    Browse the repository at this point in the history

  7. remove PreallocationTools again

    @JoshuaLampert
    JoshuaLampert committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    7f54a30 View commit details
    Browse the repository at this point in the history

  8. throw ArgumentError instead of assertion for wrong derivative_order

    @JoshuaLampert
    JoshuaLampert committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    b62f40b View commit details
    Browse the repository at this point in the history