Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more kwargs (opt_alg and verbose) to FSBP operators #279

Merged
merged 2 commits into from
Jul 18, 2024

Conversation

JoshuaLampert
Copy link
Contributor

Sometimes it can be better to use another optimization algorithm from Optim.jl than LBFGS (I have seen that BFGS sometimes outperforms LBFGS significantly). In order to easily switch between solvers, I added a kwarg to set the solver. In addition, I often want to inspect the result of the optimization procedure. To do this more easily I also added another kwarg verbose to display the result.

Copy link

codecov bot commented Jul 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.17%. Comparing base (8080cf4) to head (6015322).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #279   +/-   ##
=======================================
  Coverage   91.16%   91.17%           
=======================================
  Files          35       35           
  Lines        5311     5312    +1     
=======================================
+ Hits         4842     4843    +1     
  Misses        469      469           
Flag Coverage Δ
unittests 91.17% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@ranocha ranocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ranocha ranocha enabled auto-merge (squash) July 18, 2024 17:52
@coveralls
Copy link

Coverage Status

coverage: 91.992% (+0.001%) from 91.991%
when pulling 6015322 on JoshuaLampert:more-kwargs-fsbp
into 8080cf4 on ranocha:main.

@ranocha ranocha merged commit 87bfd2c into ranocha:main Jul 18, 2024
23 checks passed
@JoshuaLampert JoshuaLampert deleted the more-kwargs-fsbp branch July 18, 2024 18:20
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants