Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update 'latest' tags to Python 3.12 images #188

Merged
merged 1 commit into from
Sep 17, 2024
Merged

update 'latest' tags to Python 3.12 images #188

merged 1 commit into from
Sep 17, 2024

Conversation

jameslamb
Copy link
Member

@jameslamb jameslamb commented Sep 9, 2024 •
edited
Loading

Contributes to rapidsai/build-planning#40

Ensures that the images tagged :latest here use Python 3.12. Also suggests some small changes to the project's docs.

@jameslamb jameslamb added breaking Introduces a breaking change improvement Improves an existing functionality DO NOT MERGE Hold off on merging; see PR for details labels Sep 9, 2024
@jameslamb jameslamb mentioned this pull request Sep 10, 2024
Closed
5 tasks
@jameslamb jameslamb changed the title WIP: [DO NOT MERGE] update 'latest' tags to Python 3.12 images update 'latest' tags to Python 3.12 images Sep 16, 2024
@jameslamb jameslamb marked this pull request as ready for review September 16, 2024 22:01
@jameslamb jameslamb requested a review from a team as a code owner September 16, 2024 22:01
@jameslamb jameslamb requested review from AyodeAwe and removed request for a team September 16, 2024 22:01
@jameslamb jameslamb removed the DO NOT MERGE Hold off on merging; see PR for details label Sep 16, 2024
bdice
bdice approved these changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving. Note that if we have to do another hotfix of 24.08 we would need to revert this. I support merging this, now that the polars release is complete.

@jameslamb
Copy link
Member Author

Note that if we have to do another hotfix of 24.08 we would need to revert this.

Ah ok yep, that's a good point. I also agree this could be merged right now.

@jameslamb jameslamb merged commit 0b91078 into rapidsai:main Sep 17, 2024
577 checks passed
@jameslamb jameslamb deleted the python-3.12 branch September 17, 2024 14:13
@jameslamb jameslamb mentioned this pull request Sep 17, 2024
Merged
AyodeAwe pushed a commit to rapidsai/cuvs that referenced this pull request Sep 17, 2024
@jameslamb
fix style checks on Python 3.12 (#328)
e58b1d0 
After merging rapidsai/ci-imgs#188, style checks
here started breaking like this:

```text
python/cuvs/cuvs/test/test_doctests.py:103:24: E231 missing whitespace after ':'
python/cuvs/cuvs/test/test_doctests.py:124:27: E231 missing whitespace after ':'
```

([build
link](https://github.com/rapidsai/cuvs/actions/runs/10905609739/job/30264867507?pr=325))

Looks like both of those are false positives (we really do intend to not
have a space after the `:` on those lines). This proposes ignoring them
with `#noqa` comments.
@jameslamb jameslamb mentioned this pull request Sep 17, 2024
Open
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice approved these changes

@KyleFromNVIDIA KyleFromNVIDIA KyleFromNVIDIA approved these changes

@AyodeAwe AyodeAwe Awaiting requested review from AyodeAwe AyodeAwe is a code owner automatically assigned from rapidsai/ci-codeowners

Assignees
No one assigned
Labels
breaking Introduces a breaking change improvement Improves an existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jameslamb @bdice @KyleFromNVIDIA