Revert "Refactor mixed_semi_join using cuco::static_set" #16855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit e68f55c.
mhaseeb123
added
2 - In Progress
|
Investigating the issues caused by this PR. Should merge this revert if a suitable fix isn't found and will push it to 24.12 instead |
mhaseeb123
added
4 - Needs Review
mhaseeb123
added
5 - Ready to Merge
ttnghia
approved these changes
Sep 19, 2024
|
/merge |
PointKernel
approved these changes
Sep 19, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## branch-24.10 #16855 +/- ##
===============================================
Coverage ? 82.68%
===============================================
Files ? 183
Lines ? 29047
Branches ? 0
===============================================
Hits ? 24018
Misses ? 5029
Partials ? 0 ☔ View full report in Codecov by Sentry. |
bdice
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverting #16230 as this PR leads to #16852.