Change _GeoSeriesUtility._from_data(index=) default to None #1400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trxcllnt
approved these changes
Jul 2, 2024
harrism
approved these changes
Jul 2, 2024
bdice
approved these changes
Jul 2, 2024
|
/merge |
|
There is one more (potential) cudf bug that I am diagnosing to get the CI to green. |
3 tasks
|
rapidsai/cudf#16193 should unblock the remaining failure here |
rapids-bot bot
pushed a commit
to rapidsai/cudf
that referenced
this pull request
Jul 4, 2024
The offset column of a nested empty list column may be empty as discussed in #16164. `ListColumn.memory_usage` assumed that this column was non-empty Unblocks rapidsai/cuspatial#1400 Authors: - Matthew Roeschke (https://github.com/mroeschke) Approvers: - GALI PREM SAGAR (https://github.com/galipremsagar) - Lawrence Mitchell (https://github.com/wence-) URL: #16193
|
@mroeschke There are a few more CI failures here like: Can you investigate? I think this PR might be blocking #1402. |
3 tasks
Merged
bdice
approved these changes
Jul 8, 2024
bdice
reviewed
Jul 8, 2024
Comment on lines
+338
to
+343
| # TODO: Remove geopandas.dataset usage in cuspatial_api_examples.ipynb | ||
| test_notebooks: | ||
| common: | ||
| - output_types: [conda, requirements, pyproject] | ||
| packages: | ||
| - geopandas<1 |
There was a problem hiding this comment.
@mroeschke Can you open an issue documenting the geopandas<1 pinning and whatever work items need to be done there?
I am going to merge this once CI passes to unblock #1402 since it is blocking other RAPIDS-CCCL work, just want to be sure that this is visible and has a corresponding issue.
There was a problem hiding this comment.
Sure thing opened #1403
bdice
approved these changes
Jul 8, 2024
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
An upstream change in cudf uncovered a bug in
_GeoSeriesUtility._from_datawhereFalsewas being passed tocudf.Series(index=)which is an invalid value. The only validindexvalues are an actualcudf.IndexorNone, so setting toNoneas a more appropriate default valueAlso updates the location of
assert_eqwhich moved in rapidsai/cudf#16063Checklist