Add refine to public API
#154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mickael Ide <[email protected]>
cjnolet
reviewed
May 24, 2024
tfeher
requested changes
May 24, 2024
| void refine(raft::resources const& handle, | ||
| raft::host_matrix_view<const float, int64_t, raft::row_major> dataset, | ||
| raft::host_matrix_view<const float, int64_t, raft::row_major> queries, | ||
| raft::host_matrix_view<const uint32_t, int64_t, raft::row_major> neighbor_candidates, |
There was a problem hiding this comment.
Note: this is the only place where uint32_t indices are accepted. While I think it is good to handle uint32_t indices, if we do that we shall probably do for all dataset type (not only floats).
We should agree on what the supported index type shall be, and update here accordingly. I have created an issue for discussion #156.
Co-authored-by: Tamas Bela Feher <[email protected]>
cjnolet
requested changes
May 24, 2024
| /** | ||
| * @defgroup ann_refine Approximate Nearest Neighbors Refinement | ||
| * @{ | ||
| */ |
There was a problem hiding this comment.
I know it seems exhaustive and repetitive, but for documentation's sake, please copy and update the docs for each individual prototype below. We want to make sure what any function in the docs a user looks up is going to carry along the full doc string with it, not matter the type.
Signed-off-by: Mickael Ide <[email protected]>
cjnolet
approved these changes
May 28, 2024
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
cuvs::neighbors::refineto public API, with it's test